[release/9.0-staging] Don't scaffold NonNullableConventionState annotation #35359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means it gets correctly filtered out when using the model for code generation, and hence we don't try to generate a literal for it. Fixes #34996
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maumar
approved these changes
Jan 6, 2025
This was referenced Jul 22, 2025
Closed
Closed
This was referenced Oct 1, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34996
Port of #35020
Description
NonNullableConventionBaseconvention adds an annotation to the model containing a cachedNullabilityInfoContextto be used during model building. Usually, it's removed before the model is finalized, but in certain cases another convention can request it during finalization after the cache is removed causing the annotation to be added back to the model.Customer impact
An exception is thrown when adding a new migration or a compiled model for affected models (mostly with types containing a field that's a primitive collection). There is workaround via model configuration, but it's usually not practical because the exception doesn't provide any clues on what property caused it:
How found
Multiple customer reports on 8 and 9.
Regression
Yes, from 7, but started affecting even more models in 9.
Testing
Test added
Risk
Low.