Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix performance degradation in converters because the instance was not reused #36895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix performance degradation in converters because the instance was not reused #36895

wants to merge 1 commit into from
+5 −1

Conversation

cincuranet
Copy link
Contributor

Fixes #36856.

@cincuranet cincuranet marked this pull request as ready for review October 1, 2025 08:45
@cincuranet cincuranet requested a review from a team as a code owner October 1, 2025 08:45
@cincuranet cincuranet requested a review from roji October 1, 2025 08:46
@cincuranet
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 1, 2025
Open
Open
AndriySvyryd
AndriySvyryd approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on porting this to GA?

@cincuranet
Copy link
Contributor Author

Yes: #36898.

roji
roji approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we can add a DEBUG check to ensure that the shaper tree never contains a NewExpression for a ValueConverter - this would be the regression test for this. This shouldn't be too hard - we already had some validation in https://github.com/roji/efcore/blob/eb5f3905d3141dfb74dd67daed828285e483f166/src/EFCore/Query/LiftableConstantProcessor.cs#L263 (even though that's currently disabled).

See also #33517 which is referenced from that commented-out code and which is relevant to everything that's going on here (i.e. why value converters are problematic).

@cincuranet
Copy link
Contributor Author

The innerShaper (where this comes from) does not go through (at the moment) LiftableConstantProcessor. I guess we can probably plug visitor at a different spot. Is it worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression with PrimitiveCollections using a complex ValueConverter
3 participants
@cincuranet @roji @AndriySvyryd