Fix ExecuteUpdate returning -1 on open connections by setting NOCOUNT OFF#37827
Open
Abde1rahman1 wants to merge 8 commits intodotnet:mainfrom
Open
Fix ExecuteUpdate returning -1 on open connections by setting NOCOUNT OFF#37827Abde1rahman1 wants to merge 8 commits intodotnet:mainfrom
Abde1rahman1 wants to merge 8 commits intodotnet:mainfrom
Conversation
…hman1/efcore into fix/execute-update-rows-affected
Member
|
I'm not sure how this relates to #35535 - that issue doesn't mention ExecuteUpdate and doesn't seem to be about NOCOUNT specifically, but rather about triggers. Can you show exactly how this fixes #35535 via a minimal repro? If it's unrelated to #35535, please open a separate issue with a minimal repro that shows what this fixes. On that note, I don't see any test in this PR that specifically shows what it fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
When ExecuteUpdate is called on an already open connection that had a previous operation (like an Insert with identity) which enabled SET NOCOUNT ON, the subsequent ExecuteUpdate returns -1 instead of the actual rows affected. This PR prepends SET NOCOUNT OFF to the generated SQL to ensure the row count is always returned correctly.
Fixes #35535