Remove Tailwind and NPM dependency from chat template #5846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
commented
Feb 4, 2025
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940194&view=codecoverage-tab |
...ates/src/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Excellent - thanks very much! What you've done with the CSS looks perfect.
I added some minor suggestions about using CSS shorthand syntax in a few places. I'm pretty sure none of them will change the resulting styles, but it's possible I could have a typo in there so please let me know if anything looks wrong.
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <[email protected]>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <[email protected]>
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=941270&view=codecoverage-tab |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
wwwrootfolderFixes https://github.com/dotnet/ai-private-planning/issues/272
Fixes https://github.com/dotnet/ai-private-planning/issues/273
Microsoft Reviewers: Open in CodeFlow