Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introduce type converter for DataClassification #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 19, 2025
Merged

Introduce type converter for DataClassification #5887

merged 13 commits into from
Feb 19, 2025

Conversation

dariusclay
Copy link
Member

@dariusclay dariusclay commented Feb 12, 2025 •
edited
Loading

This pull request introduces a new type converter for the DataClassification struct and includes corresponding tests to ensure its functionality. The most important changes include the addition of the DataClassificationTypeConverter class, the integration of this converter into the DataClassification struct, and the creation of unit tests to validate the converter's behavior.

This improves the DataClassification type by allowing it to be bound from configuration files, enhancing the flexibility and usability of the struct in various scenarios.

Microsoft Reviewers: Open in CodeFlow

@dariusclay dariusclay marked this pull request as ready for review February 17, 2025 14:25
@dariusclay dariusclay requested a review from a team as a code owner February 17, 2025 14:25
@dariusclay dariusclay enabled auto-merge (squash) February 17, 2025 14:31
@eduherminio eduherminio self-requested a review February 17, 2025 14:49
@dariusclay
Copy link
Member Author

I'll add the experimental attribute to proper locations

@dariusclay dariusclay disabled auto-merge February 17, 2025 14:54
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Compliance.Abstractions Line 100 99.48 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetadataExtractor 57 71

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954586&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetadataExtractor 57 71

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954733&view=codecoverage-tab

@dariusclay dariusclay enabled auto-merge (squash) February 17, 2025 22:00
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetadataExtractor 57 71

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954738&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetadataExtractor 57 71

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=955108&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 82 87
Microsoft.Gen.MetadataExtractor 57 70

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=955658&view=codecoverage-tab

RussKie
RussKie reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dariusclay
Copy link
Member Author

still needing one more owner approval

@dariusclay dariusclay merged commit 152f142 into main Feb 19, 2025
6 checks passed
@dariusclay dariusclay deleted the dletterman/dataclass-typeconverter branch February 19, 2025 17:13
@rnelson rnelson mentioned this pull request Mar 12, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eduherminio eduherminio eduherminio approved these changes

@amadeuszl amadeuszl amadeuszl approved these changes

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

+1 more reviewer

@RussKie RussKie RussKie left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@dariusclay dariusclay

Labels
area-compliance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dariusclay @dotnet-comment-bot @RussKie @eduherminio @amadeuszl @evgenyfedorov2