Thanks to visit codestin.com
Credit goes to github.com

Skip to content

OpenAI: Parse detail additional property #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2025
Merged

OpenAI: Parse detail additional property #6225

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4634830
OpenAI: Parse detail additional property
jozkee Apr 1, 2025
f15cb21
Merge branch 'main' of https://github.com/dotnet/extensions into open…
jozkee Apr 1, 2025
1c0a884
Update tests to use AsIChatClient
jozkee Apr 1, 2025
4f24a33
Don't throw when type is not string
jozkee Apr 2, 2025
105cf93
Match OpenAI.Chat.ChatImageDetailLevel
jozkee Apr 2, 2025
abbb129
Merge branch 'main' of https://github.com/dotnet/extensions into open…
jozkee Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests to use AsIChatClient
  • Loading branch information
@jozkee
jozkee committed Apr 1, 2025
commit 1c0a8846e73a7541572c9be05a228233f9b82110
6 changes: 3 additions & 3 deletions test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIChatClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public async Task GetResponseAsync_OpenAIClient_DataContent_AdditionalPropertyDe
string model = "amazingModel";

var client = new OpenAIClient(new ApiKeyCredential("key"), new OpenAIClientOptions { Endpoint = endpoint });
IChatClient chatClient = client.AsChatClient(model);
IChatClient chatClient = client.GetChatClient(model).AsIChatClient();

InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(() => chatClient.GetResponseAsync(
[
Expand Down Expand Up @@ -141,14 +141,14 @@ public async Task GetResponseAsync_OpenAIClient_UriContent_AdditionalPropertyDet
string model = "amazingModel";

var client = new OpenAIClient(new ApiKeyCredential("key"), new OpenAIClientOptions { Endpoint = endpoint });
IChatClient chatClient = client.AsChatClient(model);
IChatClient chatClient = client.GetChatClient(model).AsIChatClient();

InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(() => chatClient.GetResponseAsync(
[
new(ChatRole.User,
[
new TextContent("What does this logo say?"),
new UriContent("http://my-image.png", "image/png")
new UriContent("http://localhost/my-image.png", "image/png")
{
AdditionalProperties = new()
{
Expand Down
Loading