Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Restore deleted members as obsolete #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

Restore deleted members as obsolete #6304

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0037b3
Restore EmbeddingGeneratorExtensions members as obsolete
jeffhandley Apr 16, 2025
53bfc1a
Restore ChatThreadId as obsolete
jeffhandley Apr 16, 2025
ddd8d10
Restore ChatResponse.ChatThreadId and ChatResponseUpdate.ChatThreadId…
jeffhandley Apr 16, 2025
9918c16
Remove the tests for obsolete members
jeffhandley Apr 16, 2025
662c8ce
Remove the Embeddings tests for obsolete members
jeffhandley Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove the Embeddings tests for obsolete members
  • Loading branch information
@jeffhandley
jeffhandley committed Apr 16, 2025
commit 662c8ced6d2eb6879ec0f340f67183b7a772dfb5
8 changes: 0 additions & 8 deletions ...icrosoft.Extensions.AI.Abstractions.Tests/Embeddings/EmbeddingGeneratorExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ public void GetService_ValidService_Returned()
public async Task GenerateAsync_InvalidArgs_ThrowsAsync()
{
await Assert.ThrowsAsync<ArgumentNullException>("generator", () => ((TestEmbeddingGenerator)null!).GenerateAsync("hello"));
#pragma warning disable CS0618 // Type or member is obsolete
await Assert.ThrowsAsync<ArgumentNullException>("generator", () => ((TestEmbeddingGenerator)null!).GenerateEmbeddingVectorAsync("hello"));
#pragma warning restore CS0618 // Type or member is obsolete
await Assert.ThrowsAsync<ArgumentNullException>("generator", () => ((TestEmbeddingGenerator)null!).GenerateVectorAsync("hello"));
await Assert.ThrowsAsync<ArgumentNullException>("generator", () => ((TestEmbeddingGenerator)null!).GenerateAndZipAsync(["hello"]));
}
Expand All @@ -97,11 +94,6 @@ public async Task GenerateAsync_ReturnsSingleEmbeddingAsync()
Task.FromResult<GeneratedEmbeddings<Embedding<float>>>([result])
};

#pragma warning disable CS0618 // Type or member is obsolete
Assert.Same(result, await service.GenerateEmbeddingAsync("hello"));
Assert.Equal(result.Vector, await service.GenerateEmbeddingVectorAsync("hello"));
#pragma warning restore CS0618 // Type or member is obsolete

Assert.Same(result, await service.GenerateAsync("hello"));
Assert.Equal(result.Vector, await service.GenerateVectorAsync("hello"));
}
Expand Down
Loading