Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add resiliency to Resource Monitoring in Linux #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025
Merged

Add resiliency to Resource Monitoring in Linux #6489

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
babbd62
Add resiliency for Linux networking metrics
amadeuszl Jun 2, 2025
df89898
Remove unnecessary test
amadeuszl Jun 2, 2025
1486e53
Add resiliency to disk stats
amadeuszl Jun 2, 2025
d3c765c
Fix build issues
amadeuszl Jun 5, 2025
01b3837
Address comments, improve performance, refactor
amadeuszl Jun 9, 2025
59bb11e
Switch logging to extension methods
amadeuszl Jun 10, 2025
90d645a
Merge branch 'main' into alechniak/resiliency-in-resource-monitoring
amadeuszl Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary test
  • Loading branch information
@amadeuszl
amadeuszl committed Jun 2, 2025
commit df898984dc213ec4a33f4e199007f21b5ab39782
56 changes: 0 additions & 56 deletions ...crosoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Linux/LinuxNetworkMetricsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,60 +134,4 @@ private LinuxNetworkMetrics CreateMetrics()
_tcpStateInfoProvider.Object,
_timeProvider);
}
[Fact]
public void GetTcpStateInfoWithRetry_Multithreaded_RetryIsThreadSafe()
{
// Arrange
var callCount = 0;
var lockObj = new object();
_tcpStateInfoProvider.Setup(p => p.GetIpV4TcpStateInfo()).Returns(() =>
{
lock (lockObj)
{
callCount++;
if (callCount == 1)
{
throw new FileNotFoundException();
}
return new TcpStateInfo { ClosedCount = 55 };
}
});

var metrics = CreateMetrics();
var results = new List<List<Measurement<long>>>();
var threads = new Thread[5];

// Act
for (int i = 0; i < threads.Length; i++)
{
threads[i] = new Thread(() =>
{
// Each thread tries to get measurements
results.Add(metrics.GetMeasurements().ToList());
});
threads[i].Start();
}
foreach (var t in threads)
{
t.Join();
}

// Advance time to after retry interval
_timeProvider.Advance(TimeSpan.FromMinutes(6));

// All threads should have received default (0) values due to retry interval
foreach (var measurementList in results)
{
Assert.All(measurementList.Take(11), m => Assert.Equal(0, m.Value));
}

// Now, after retry interval, the next call should succeed and return the new value
var afterRetry = metrics.GetMeasurements().ToList();
Assert.Equal(55, afterRetry[0].Value);
Assert.Contains(afterRetry, m => HasTagWithValue(m, "network.type", "ipv4", 55));
Assert.Contains(afterRetry, m => HasTagWithValue(m, "system.network.state", "close", 55));

// Only two calls to GetIpV4TcpStateInfo should have been made (one fail, one after retry)
_tcpStateInfoProvider.Verify(p => p.GetIpV4TcpStateInfo(), Times.Exactly(2));
}
}