Target .NET 8 for more stable runtime requirement #6617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCP server templates to require .NET 8 or newer at runtime and bumps the hosting package preview version.
- Changed C# templates and snapshots to target
net8.0and added aRollForwardpolicy. - Updated
GeneratedContent.targetsto useMicrosoft.Extensions.Hostingpreview 6. - Refreshed integration test snapshots to match the new template outputs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/ProjectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/Snapshots/mcpserver.Basic.verified/mcpserver/mcpserver.csproj | Updated target framework to net8.0 and added <RollForward>LatestMajor</RollForward> in the snapshot |
| src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/McpServer/McpServer-CSharp/McpServer-CSharp.csproj.in | Changed TargetFramework to net8.0 and added <RollForward>LatestMajor</RollForward> in the C# template input |
| src/ProjectTemplates/GeneratedContent.targets | Bumped <TemplatePackageVersion_MicrosoftExtensionsHosting> to 10.0.0-preview.6.25358.103 |
Comments suppressed due to low confidence (2)
src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/McpServer/McpServer-CSharp/McpServer-CSharp.csproj.in:5
- [nitpick] Consider adding or updating an integration test to verify that the generated runtimeconfig.json for net8.0 templates includes the RollForward setting.
<RollForward>LatestMajor</RollForward>
src/ProjectTemplates/GeneratedContent.targets:38
- [nitpick] Consider centralizing template package version definitions or using a shared MSBuild property so you only need to bump the version in one place.
<TemplatePackageVersion_MicrosoftExtensionsHosting>10.0.0-preview.6.25358.103</TemplatePackageVersion_MicrosoftExtensionsHosting>
baronfel
reviewed
Jul 16, 2025
.../Microsoft.Extensions.AI.Templates/src/McpServer/McpServer-CSharp/McpServer-CSharp.csproj.in
Outdated
Show resolved
Hide resolved
jeffhandley
approved these changes
Jul 16, 2025
Oops, push was hung. Done. |
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Jul 16, 2025
* Target .NET 8 for more stable runtime requirement * Address comment
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Jul 16, 2025
* Target .NET 8 for more stable runtime requirement * Address comment
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Jul 16, 2025
* Target .NET 8 for more stable runtime requirement * Address comment
jeffhandley
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Target .NET 8 for more stable runtime requirement * Address comment
This was referenced Aug 13, 2025
Merged
This was referenced Aug 15, 2025
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP Servers built with preview .NET SDK 6 and 7 are currently stamped with a .NET 10 preview runtime requirement. This is okay for a given SDK+runtime version but is painful when the next preview or GA come out because they are different runtime versions. In other words, .NET 10 Preview 6 runtime is a different runtime version from Preview 7 and from .NET 10.0.0 (stable version, starting with RC1).
This PR also bumps to the latest version on Microsoft.Extensions.Hosting, which is compatible with .NET 8.
This PR makes it so the MCP servers are stamped with a
.NET 8 or newer (preferring .NET 8 if present)runtime requirement.OLD
<assembly name>.runtimeconfig.jsonfile put in the .nupkg (problematic):{ "runtimeOptions": { "tfm": "net10.0", "framework": { "name": "Microsoft.NETCore.App", "version": "10.0.0-preview.6.25326.107" }, "configProperties": { "System.Reflection.Metadata.MetadataUpdater.IsSupported": false, "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false } } }NEW
<assembly name>.runtimeconfig.jsonfile (better):{ "runtimeOptions": { "tfm": "net8.0", "rollForward": "Major", "framework": { "name": "Microsoft.NETCore.App", "version": "8.0.0" }, "configProperties": { "System.Reflection.Metadata.MetadataUpdater.IsSupported": false, "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false } } }