Fix M.E.AI package refs #6654
Fix M.E.AI package refs #6654
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes package references in Microsoft.Extensions.AI libraries by conditionally including certain System package dependencies only when the target framework is not .NET Core App. This optimization leverages the fact that .NET Core App already includes these packages in its base class libraries.
- Conditionally includes System.* package references only for non-.NET Core App targets
- Separates unconditional package references from conditional ones using distinct ItemGroup elements
- Applies consistent pattern across four Microsoft.Extensions.AI library projects
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.Extensions.AI.csproj | Separates System package references into conditional ItemGroup for non-.NET Core App targets |
| Microsoft.Extensions.AI.OpenAI.csproj | Moves System.Memory.Data and System.Text.Json to conditional ItemGroup |
| Microsoft.Extensions.AI.Ollama.csproj | Adds condition to existing ItemGroup for System package references |
| Microsoft.Extensions.AI.AzureAIInference.csproj | Separates System package references into conditional ItemGroup |
src/Libraries/Microsoft.Extensions.AI.OpenAI/Microsoft.Extensions.AI.OpenAI.csproj
Show resolved
Hide resolved
eeb47e0 to
b782004
Compare
|
This PR seems to be the reason the main branch builds are broken on SourceIndexStage1 job. |
I'm having trouble deciphering the dependency output there. @ericstj, it looks like something is referencing STJ 6.0 and S.D.DiagnosticSource 6.0 packages and that's causing a conflict? |
|
@joperezr said he would take a look at it |
|
Something weird about the build of https://github.com/dotnet/extensions/blob/main/src/Packages/Microsoft.Internal.Extensions.DotNetApiDocs.Transport/Microsoft.Internal.Extensions.DotNetApiDocs.Transport.proj I would expect it to get the latest System.Diagnostics.DiagnosticSource which is brought in transitively by the projects it references, but instead it's getting an older version. Something fishy with how that project is set up. I see @joperezr already worked around a similar bug before 424e974 |
|
@sebastienros / @joperezr , did this get resolved? |
|
From what I see, not resolved |
Microsoft Reviewers: Open in CodeFlow