Fix 16071 --- FSharp.DependencyManager.Nuget ignoring sources #16991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
vzarytovskii
approved these changes
Apr 5, 2024
|
/run fantomas |
Co-authored-by: KevinRansom <[email protected]>
|
Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/8586346201 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
approved these changes
Apr 8, 2024
psfinaki
added a commit
that referenced
this pull request
Apr 8, 2024
#17003) * Fix 16071 * tweaks * Automated command ran: fantomas Co-authored-by: KevinRansom <[email protected]> --------- Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Petr <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]>
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16071
One of the mechanisms for providing sources to a project file for nuget package resolution is to add a Nuget.config file with add source elements.
In the package manager we use
dotnet nuget list sources -format detailedto retrieve these sources. The regex for retrieving the uri from the output did not allow for paths containing spaces. This PR fixes the regex to allow for spaces.Todo: