Add --is-diffs-only and --is-subset-of-diffs #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing for jit-analyze to display this summary when invoked through SPMI, since SPMI will only .dasm files for some contexts. Add some options to control the summary written.
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS Need this for dotnet/runtime#76238 which will otherwise make this summary even more confusing, since SPMI will stop generating .dasm files for all contexts with diffs after that change. |
|
In the long run it would probably be better to have jit-analyze return something machine readable that superpmi.py could consume and format how it wishes, but it's a bit more work than I want to sign up for now. |
kunalspathak
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing for jit-analyze to display this summary when invoked through SPMI since SPMI will only create .dasm files for some contexts. Add some options to control the summary written.