Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn by default #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2020
Merged

Warn by default #1372

merged 3 commits into from
Aug 4, 2020

Conversation

mateoatr
Copy link
Contributor

Log warnings and errors regardless of the --verbose option.

Dependent upon dotnet/runtime#39133.

@mateoatr mateoatr requested a review from marek-safar as a code owner July 21, 2020 04:19
@mateoatr mateoatr self-assigned this Jul 21, 2020
vitek-karas
vitek-karas reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests validating the behavior of the various messages? It might need some infra work though.

sbomer
sbomer approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you add a test for the default behavior

@sbomer
Copy link
Member

sbomer commented Jul 30, 2020

@layomia added bulk suppressions for warnings in runtime (dotnet/runtime#40106), so I think this is unblocked.

@sbomer
Copy link
Member

sbomer commented Jul 31, 2020

For testing, maybe it would be enough to remove --verbose from the default test options: https://github.com/mono/linker/blob/7c9b806037e88df7eb40a8151808730133676668/test/Mono.Linker.Tests/TestCasesRunner/TestCaseMetadaProvider.cs#L90 and add it explicitly for any tests that check informational messages?

@mateoatr
Copy link
Contributor Author

For testing, maybe it would be enough to remove --verbose from the default test options:

https://github.com/mono/linker/blob/7c9b806037e88df7eb40a8151808730133676668/test/Mono.Linker.Tests/TestCasesRunner/TestCaseMetadaProvider.cs#L90

and add it explicitly for any tests that check informational messages?

Yes, I think this should be enough, although I think this could impact #1385. @vitek-karas should I wait until the warnings cleanup is merged?

agocke
agocke reviewed Jul 31, 2020
View reviewed changes
@mateoatr mateoatr mentioned this pull request Aug 3, 2020
Closed
@mateoatr mateoatr merged commit a3d706a into dotnet:master Aug 4, 2020
tkapin pushed a commit to tkapin/runtime that referenced this pull request Jan 31, 2023
@mateoatr
Warn by default (dotnet/linker#1372)
52efd6b 
* Always log warnings and errors

Commit migrated from dotnet/linker@a3d706a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocke agocke agocke left review comments

@vitek-karas vitek-karas vitek-karas left review comments

@marek-safar marek-safar marek-safar approved these changes

@sbomer sbomer sbomer approved these changes

Assignees

@mateoatr mateoatr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mateoatr @sbomer @marek-safar @agocke @vitek-karas