Fix a small bug in message origin for warnings from static field access on generic type #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss on generic type The warning needs to be generated from the origin where the field reference comes from - so if it's a method body, then from the method body. This is because the instantiation is determined by that place, not the field itself (the field is defined on an open generic definition of the type). This syncs the relevants tests with a NativeAOT work-in-progress change, but in generately it adds a lot more cases and some better comments.
tlakollo
approved these changes
Jan 16, 2023
test/Mono.Linker.Tests.Cases/DataFlow/GenericParameterWarningLocation.cs
Outdated
Show resolved
Hide resolved
test/Mono.Linker.Tests.Cases/DataFlow/GenericParameterWarningLocation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tlakaelel Axayakatl Ceja <[email protected]>
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Jan 31, 2023
…ss on generic type (dotnet/linker#3186) The warning needs to be generated from the origin where the field reference comes from - so if it's a method body, then from the method body. This is because the instantiation is determined by that place, not the field itself (the field is defined on an open generic definition of the type). This syncs the relevants tests with a NativeAOT work-in-progress change, but in generately it adds a lot more cases and some better comments. Co-authored-by: Tlakaelel Axayakatl Ceja <[email protected]> Commit migrated from dotnet/linker@c790896
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Jan 31, 2023
…ss on generic type (dotnet/linker#3186) The warning needs to be generated from the origin where the field reference comes from - so if it's a method body, then from the method body. This is because the instantiation is determined by that place, not the field itself (the field is defined on an open generic definition of the type). This syncs the relevants tests with a NativeAOT work-in-progress change, but in generately it adds a lot more cases and some better comments. Co-authored-by: Tlakaelel Axayakatl Ceja <[email protected]> Commit migrated from dotnet/linker@c790896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning needs to be generated from the origin where the field reference comes from - so if it's a method body, then from the method body. This is because the instantiation is determined by that place, not the field itself (the field is defined on an open generic definition of the type).
This syncs the relevants tests with a NativeAOT work-in-progress change, but in generately it adds a lot more cases and some better comments.