Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add diskConvert option in fast tree search space #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 11, 2023
Merged

add diskConvert option in fast tree search space #6316

merged 6 commits into from
May 11, 2023

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Sep 8, 2022 •
edited
Loading

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#6297

LittleLittleCloud
LittleLittleCloud commented Sep 8, 2022
View reviewed changes
src/Microsoft.ML.AutoML/CodeGen/fast_tree_search_space.json
@@ -75,6 +75,11 @@
{
"name": "ExampleWeightColumnName",
"type": "string"
},
{
"name": "DiskTranspose",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option allows user to overwrite DiskTranspose when necessary, which avoids OOM when dataset is large

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@michaelgsharp
Copy link
Contributor

@LittleLittleCloud you have this tagged as WIP, is it still in progress?

@LittleLittleCloud LittleLittleCloud changed the title wip - add diskConvert option in fast tree search space add diskConvert option in fast tree search space May 10, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #6316 (abad9ef) into main (247f3a0) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6316      +/-   ##
==========================================
+ Coverage   68.59%   68.77%   +0.18%     
==========================================
  Files        1201     1215      +14     
  Lines      250296   251523    +1227     
  Branches    26094    26227     +133     
==========================================
+ Hits       171681   172992    +1311     
+ Misses      71802    71721      -81     
+ Partials     6813     6810       -3
Flag Coverage Δ
Debug 68.77% <ø> (+0.18%) ⬆️
production 63.29% <ø> (+0.22%) ⬆️
test 88.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 57 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 4a11ac0 into dotnet:main May 11, 2023
@torronen torronen mentioned this pull request May 15, 2023
Closed
@LittleLittleCloud LittleLittleCloud mentioned this pull request May 23, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@michaelgsharp michaelgsharp michaelgsharp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@LittleLittleCloud LittleLittleCloud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LittleLittleCloud @michaelgsharp