Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Match SweepableEstimatorFactory name with Ml.net name. #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

Match SweepableEstimatorFactory name with Ml.net name. #7007

merged 1 commit into from
Feb 21, 2024

Conversation

zewditu
Copy link
Contributor

@zewditu zewditu commented Feb 16, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64523e8) 68.81% compared to head (32b4522) 68.80%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7007      +/-   ##
==========================================
- Coverage   68.81%   68.80%   -0.02%     
==========================================
  Files        1258     1258              
  Lines      250477   250652     +175     
  Branches    25576    25602      +26     
==========================================
+ Hits       172377   172465      +88     
- Misses      71473    71554      +81     
- Partials     6627     6633       +6
Flag Coverage Δ
Debug 68.80% <ø> (-0.02%) ⬇️
production 63.27% <ø> (-0.02%) ⬇️
test 88.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@build-analysis build-analysis bot mentioned this pull request Feb 16, 2024
Open
@michaelgsharp michaelgsharp merged commit a1b7e1d into dotnet:main Feb 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LittleLittleCloud LittleLittleCloud LittleLittleCloud approved these changes

Assignees

@zewditu zewditu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewditu @LittleLittleCloud @michaelgsharp