[Testing] Fix TapCoordinates method in Catalyst #29775
Merged
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the TapCoordinates and DoubleTapCoordinates methods to correctly handle Catalyst by directly invoking the existing coordinate-based click/double-click operations for AppiumCatalystApp, and removes obsolete compilation directives from shared test cases to improve clarity.
- Add conditional branches in
TapCoordinatesandDoubleTapCoordinatesto support Catalyst without compiler flags. - Remove
#if MACCATALYSTdirectives in shared UI tests, usingTapCoordinatesconsistently. - Clean up outdated XML doc comments referencing Catalyst issues.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HelperExtensions.cs | Added if (app is AppiumCatalystApp) branches for coordinate taps/double taps; removed outdated summary lines |
| Issue2894.cs | Removed Catalyst-specific compilation guard in PerformGestureAction, always using TapCoordinates |
| Issue12685.cs | Simplified test to use TapCoordinates for all platforms; minor comment cleanup |
Comments suppressed due to low confidence (3)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:405
- The XML doc for
DoubleTapCoordinatesandTapCoordinatesshould be updated to mention Catalyst support, reflecting that these methods now work on AppiumCatalystApp without compiler directives.
public static void DoubleTapCoordinates(this IApp app, float x, float y)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue2894.cs:47
- Consider adding or updating a UI test in the HostApp to explicitly verify that
TapCoordinatesworks on Mac Catalyst to ensure this fix is covered end-to-end.
App.TapCoordinates(x, y);
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:408
- The call to
app.DoubleClickCoordinatesreferences a method that doesn’t exist in this class. Consider renaming it toapp.DoubleTapCoordinatesor implementing theDoubleClickCoordinatesextension.
app.DoubleClickCoordinates(x, y); // Directly invoke coordinate-based double click for AppiumCatalystApp.
|
Should the OP contain |
Right, updated the PR description. |
|
/rebase |
4241171 to
60ba128
Compare
rmarinho
approved these changes
Jun 5, 2025
PureWeen
added a commit
that referenced
this pull request
Jun 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix
TapCoordinatesmethod in Catalyst. No longer requires to use compilation directives in tests, , improving clarity and maintainability.Fixes #19754