[2025/06/23] Candidate - In Flight Branch #30115
Merged
+3,796
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR includes broad platform-specific enhancements, converter optimizations, memory‐leak safeguards, and updated samples/tests across iOS, Android, Windows, and core libraries.
- Refactored image scaling on iOS and added multiple‐touch support in graphics views.
- Introduced weak command subscriptions and optimized type converters using pooling.
- Extended test/benchmark suites and updated host‐app samples for features like Picker, SearchBar, Button, and BoxView.
Reviewed Changes
Copilot reviewed 95 out of 233 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Graphics/src/Graphics/Platforms/iOS/UIImageExtensions.cs | Switched renderer size; added disposeOriginal flag |
| src/Core/tests/Benchmarks/Benchmarks/GridDefinitionBenchmarker.cs | New benchmarks for row/column converters |
| src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt | Removed Android Picker and TextView APIs |
| src/Core/src/Platform/iOS/PlatformTouchGraphicsView.cs | Enabled MultipleTouchEnabled by default |
| src/Core/src/Platform/Windows/SearchBarExtensions.cs | Extended UpdateColors to call RefreshThemeResources |
| src/Core/src/Platform/Android/ViewExtensions.cs | Improved unload checks with IsAlive() guard |
| src/Core/src/Platform/Android/PickerManager.cs | Simplified Init and removed old key handlers |
| src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs | Refactored cell invalidation logic |
Comments suppressed due to low confidence (3)
src/Graphics/src/Graphics/Platforms/iOS/UIImageExtensions.cs:30
- The
disposeOriginalparameter is never used: ifdisposeOriginalis true, the originaltargetimage should be disposed to avoid leaking the original UIImage.
using (var renderer = new UIGraphicsImageRenderer(size))
src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs:217
- The new collection expression
[]produces an array, butinvalidatedCellsis a List; this will not compile. Replace withnew List<TemplatedCell2>()or the appropriate collection initializer.
invalidatedCells ??= [];
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs:253
- Same issue here:
[]yields an array, not a List. Usenew List<TemplatedCell>()to initialize the list.
invalidatedCells ??= [];
This was referenced Jun 23, 2025
|
/rebase |
1 similar comment
|
/rebase |
ea65e77 to
ea1b786
Compare
|
/rebase |
109915b to
4a4dfb4
Compare
4a4dfb4 to
13004a6
Compare
|
/rebase |
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
…roundColor #22914 (#22917) * Fixes #22914 * Add tests Add tests for appium * Fix the build * Use VerifyScreenshot * @jsuarezruiz suggested changes --------- Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]>
* Fixed the picker title's color (#16737) * Added a test category * Enable test on all platforms
If no QueryIcon / ClearIcon is specified use default icon.
* button test cases added * added clear text line * changes * added test fails condition * updated test cases * updated the test cases * updated test cases * added additional test cases * removed test case * added snapshots * added the windows and mac snapshots * removed snapshots * added additional properties * added mac and windows snapshots
* harish_feature_matrix_boxview * Added the Snapshots * Updated the Snapshots * Renamed the file * Added property and Updated Snaps * Resaved Snapshots from latest build
…on (#20048) * add benchmarks * set CanConvertTo to be consistent with the ColumnDefinitionTypeConverter * optimize GridLength conversion * optimize grid definition conversion * enable nullable types * fix build * reduce diff * Slightly better * Update RowDefinition.cs * Even better --------- Co-authored-by: Edward Miller <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]>
) * Update ViewExtensions.cs * Update ViewExtensions.cs * Update ViewExtensions.cs * - unsubscribe sooner --------- Co-authored-by: Shane Neuville <[email protected]>
…nd BackgroundColor (#29965) * Fixed SearchBar color issues * Added test sample * Added Windows and Mac snapshots
* Add Button to HandlerDoesNotLeak test * add ProgressBar to HandlerDoesNotLeak
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Weak subscription to CanExecuteChange events * - add tests * - fix lifecycle of CanExecute subscription * - cleanup code based on Pictos recommendations * - add a netstandard_20 version of DependentHandle * - add more * - fix missing null check on textcell
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
* make picker not focisable # Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt * Address review comments * set keylistner to null * Make sure Focus()/Unfocus() works * Address review comments * Remove IsFocused Checks
* Reverting the OnMeasure changes and 27614 test cases * Resaved the Android images * Change in unshipped file
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…resizing when bounds change (#29639) * Fix CV1 empty view not resizing when bounds change and grid layout not left aligning single item * - rework test * - fix test --------- Co-authored-by: Shane Neuville <[email protected]>
#30136) * Resaved the Snapshots * Update ImagePaintWithDownsize.png * update mac image * Updated test failures * Added mac and windows images from CI --------- Co-authored-by: Anandhan Rajagopal <[email protected]>
* Added-28051-Test * Removed-keyword * Added-Test-For-All-Platforms
13004a6 to
0175e3c
Compare
mattleibow
approved these changes
Jun 27, 2025
prakashKannanSf3972
added a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Jul 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
.NET MAUI Release Notes - Inflight/Candidate Branch
What's Changed
MAUI Product Fixes
RefreshViewcan have a memory leak with a customICommand#16124 by @sneumaier in Weak subscription to CanExecuteChange events #29837Testing
Dependency Updates
Housekeeping
New Contributors
Full Changelog: https://github.com/dotnet/maui/compare/main..inflight/candidate