Remove Conversion.Core registrations#10817
Merged
JanKrivanek merged 2 commits intomainfrom Oct 17, 2024
Merged
Conversation
YuliiaKovalova
approved these changes
Oct 15, 2024
Member
Author
|
Experimental VS insertion PR: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/585404 - everything is pasing (incl DDRITs) except expectedfailure in sdk install test (due to missing packages) (note: I'm repurposing the exp insertion for implanting and testing followup Build.Engine removal work - so future state of the isertion is not guaranteed and doesn't mean bad state of this particular PR) |
maridematte
approved these changes
Oct 16, 2024
YuliiaKovalova
added a commit
that referenced
this pull request
Oct 18, 2024
This reverts commit b8f46eb.
YuliiaKovalova
added a commit
that referenced
this pull request
Oct 18, 2024
YuliiaKovalova
added a commit
that referenced
this pull request
Oct 19, 2024
YuliiaKovalova
added a commit
that referenced
this pull request
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #8826
Context
Microsoft.Build.Conversion.Core was removed in VS codebase by https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/583701 However Microsoft.Build component still keeps dragging the binary to the VS install. Let's make sure Microsoft.Build.Conversion.Core.dll is not part of the VS install before we remove the code alltogether
Changes Made
Removing the registrations of Microsoft.Build.Conversion.Core, that contributes to VS install