[vs17.13] Don't mark synthesized projects dirty when SDKs define properties #11478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot be marked dirty
Co-authored-by: Rainer Sigwald <[email protected]>
Try disabling AV in the official build script to avoid build breaks that manifest as ``` D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24516.2\tools\Sign.proj(72,5): error MSB4018: The "Microsoft.DotNet.SignTool.SignToolTask" task failed unexpectedly. System.Runtime.Serialization.SerializationException: Type 'System.AssemblyLoadEventArgs' in assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable. at Microsoft.Build.BackEnd.Components.RequestBuilder.AssemblyLoadsTracker.CurrentDomainOnAssemblyLoad(Object sender, AssemblyLoadEventArgs args) at System.AppDomain.OnAssemblyLoadEvent(RuntimeAssembly LoadedAssembly) at Microsoft.Build.Framework.ITask.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24516.2\tools\Sign.proj] ``` --------- Co-authored-by: Jan Provaznik <[email protected]>
|
This is approved by tactics in #11454 |
rainersigwald
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #11394
This is a regression. The bug appeared after Expand MSBuildSdkResolver.
Customer impact
Without this fix the customers that opt-into
MsBuildUseSimpleProjectRootElementCacheConcurrencywill getSystem.NotImplementedException. This includesslngenandquickbuild.Details
The
NotImplementedExceptionis thrown here:msbuild/src/Build/Evaluation/SimpleProjectRootElementCache.cs
Lines 133 to 136 in aff5455
Previously the
SdkResultofMSBuildSdkResolverwas empty andProjectRootElementwas never created for it. Now, it contains 2 properties, and whenProjectRootElementis created, every change marks it as dirty. The fix is not to mark it dirty when it is fromSdkResultChanges made
Implemented internal
CreateNotDirtythat createsProjectRootElementthat cannot be dirtied.Testing
Added unit test for
CreateNotDirty. Also manually tested that the exception is not thrown anymore.Risks
Low - existing tests ensure that other scenarios are not broken, added new test, also tested manually this exact case.