Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert ".slnx support - use the new parser for .sln and .slnx (#10836)" #11488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rainersigwald
Copy link
Member

Don't use the new parser from Microsoft.VisualStudio.SolutionPersistence to parse .sln files.

Fixes #11463

Work item (Internal use): AB#2397817

Summary

Revert #10836 to return to the longstanding MSBuild private .sln parser (but keep using the SolutionPersistence library for .slnx).

Customer Impact

Three categories of problem:

All manifest as build or NuGet restore breaks with no obvious workaround (but once discovered the changewave opt-out environment variable works).

Regression?

Yes, in 17.13/9.0.200 due to adopting the common SolutionPersistence library instead of our homegrown sln parser.

Testing

Unit tests + manual scenario tests.

Risk

Low, clean revert to earlier behavior for .sln.

@rainersigwald rainersigwald requested a review from a team as a code owner February 24, 2025 22:09
…#10836)"

This reverts commit 2e2d372.

This will avoid problems arising from using the new library in NuGet.exe
scenarios and bugs in the library.

Conflicts:
	documentation/wiki/ChangeWaves.md
	src/Framework/ChangeWaves.cs
@rainersigwald rainersigwald force-pushed the revert-SolutionPersistence-for-sln branch from 2ac2af3 to 39e0043 Compare February 24, 2025 22:28
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean revert, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants