Thanks to visit codestin.com
Credit goes to github.com

Skip to content

asking terminal for dimensions during every frame is expensive #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
+16 −3
Merged

asking terminal for dimensions during every frame is expensive #11504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f81a3d
asking terminal for dimensions during every frame is expensive
SimaTian Feb 26, 2025
68351f8
default change
SimaTian Feb 26, 2025
20a1cfe
added a comment for the future
SimaTian Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/Build/Logging/TerminalLogger/TerminalLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,11 +1058,22 @@ private void ErrorRaised(object sender, BuildErrorEventArgs e)
private void ThreadProc()
{
// 1_000 / 30 is a poor approx of 30Hz
var count = 0;
while (!_cts.Token.WaitHandle.WaitOne(1_000 / 30))
{
count++;
lock (_lock)
{
DisplayNodes();
// Querying the terminal for it's dimensions is expensive, so we only do it every 30 frames e.g. once a second.
if (count >= 30)
{
count = 0;
DisplayNodes();
}
else
{
DisplayNodes(false);
}
}
}

Expand All @@ -1073,9 +1084,11 @@ private void ThreadProc()
/// Render Nodes section.
/// It shows what all build nodes do.
/// </summary>
internal void DisplayNodes()
internal void DisplayNodes(bool updateSize = true)
{
TerminalNodesFrame newFrame = new TerminalNodesFrame(_nodes, width: Terminal.Width, height: Terminal.Height);
var width = updateSize ? Terminal.Width : _currentFrame.Width;
var height = updateSize ? Terminal.Height : _currentFrame.Height;
TerminalNodesFrame newFrame = new TerminalNodesFrame(_nodes, width: width, height: height);

// Do not render delta but clear everything if Terminal width or height have changed.
if (newFrame.Width != _currentFrame.Width || newFrame.Height != _currentFrame.Height)
Expand Down