Add A/B option to test if disabling 'recoverable text' helps/hurts us #67845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
genlu
reviewed
Apr 24, 2023
| [property: DataMember(Order = 2)] bool DisableSharedSyntaxTrees = false, | ||
| [property: DataMember(Order = 3)] bool DeferCreatingRecoverableText = false) | ||
| [property: DataMember(Order = 3)] bool DeferCreatingRecoverableText = false, | ||
| [property: DataMember(Order = 4)] bool DisableRecoverableText = false) |
There was a problem hiding this comment.
Do we still need DeferCreatingRecoverableText?
There was a problem hiding this comment.
yes. two separate experiements. one is if we have the concept at all. the second is if we defer makign the recoverable text to a later point in time :)
genlu
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #67843.
'recoverable text' is what lets us dump source-texts from memory to memory mapped files. There's a lot of complexity here (as well as crashes :)) that woudl be nice to get rid of. Now we're always 64bit, it seems possible we don't need any of this anymore as we just have all the 64bit address space to work with.
Adding an option for this so we can A/B test this and see if we run into any issues.