Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented May 12, 2023

Manual conflict resolutions in 9e251f6

genlu and others added 30 commits November 16, 2022 12:52
…ionCapability

[17.6] Only send workspace/configuration request when client supports that
…match (dotnet#66992)

* Add tests

* Check count before reusing batched items

* Add missing assert

* Fix local function name casing

* Fix notation in comment

* Revert "Check count before reusing batched items"

This reverts commit 2984b5f.

* Check state table counts before caching

* Clarify doc comment

* Add a test

Co-authored-by: Chris Sienkiewicz <[email protected]>

* Compute `IsCached` flag only in the builder

---------

Co-authored-by: Chris Sienkiewicz <[email protected]>
* Use exception with specific type and HResult to aid tracking in telemetry

* Associate rude edits with project id
RadwanFaci and others added 9 commits May 10, 2023 20:21
* Check if DocCookie is int instead of uint

* Make doc cookie cast more resilient
…ptionsChange

Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction
…med-types and methods. (dotnet#68131)

* Use a singleton for empty type-parameters for named types

* move type parameters down

* Optimize methods as well

* Always create indirection

* Move type

* Apply suggestions from code review

* speeling

* nrt

* Inline

* Simplify

* Change to abstract override
* Record added node output states as new

The `(EntryState.Modified, EntryState.Added) => IncrementalStepRunReason.Modified` state mapping was recently added in dotnet#61308, but doesn't look correct to me. Since this value is used as the output status, and the outputs are new, I believe the correct state should be `IncrementalStepRunReason.New` instead.

* Update tests that were added since I originally implemented the change

* Update documentation for IncrementalStepRunReason

* Update VB tests also

* Add note about breaking changes with IncrementalStepRunReason

---------

Co-authored-by: Jan Jones <[email protected]>
* Add a test

* Display standalone parameter names by default

* Document breaking change

* Update tests
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 12, 2023
@RikkiGibson RikkiGibson marked this pull request as ready for review May 12, 2023 23:58
@RikkiGibson RikkiGibson requested review from a team, 333fred and dibarbet as code owners May 12, 2023 23:58
@RikkiGibson RikkiGibson requested review from a team and removed request for a team, 333fred and dibarbet May 12, 2023 23:58
@RikkiGibson RikkiGibson merged commit f130bb4 into dotnet:features/interceptors May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.