Disable ExtractMethod and VerifyTextSync after 17.9P1 failures #71089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
reviewed
Dec 4, 2023
| } | ||
|
|
||
| [IdeFact] | ||
| [IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/71088")] |
There was a problem hiding this comment.
Note - we don't have to skip these now (they are passing on the current images). But if we don't fix them by the time the queue upgrades, we will need to do this.
There was a problem hiding this comment.
3 tasks
dibarbet
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Approving - the scouting queue is upgrading tomorrow, so we should get this PR in before that happens
https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/899/VS2022-Upgrade-Schedule
FYI @sharwell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged if #71088 is not fixed before scouting queue gets promoted to regular queue.