Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jaredpar
Copy link
Member

@jaredpar jaredpar commented Dec 6, 2023

Get our devcontainer up to date with our current setup. Mostly just moving to the 8.0 images. Verified this works on my local setup using roslyn in a Docker volume

Get our devcontainer up to date with our current setup. Mostly just
moving to the 8.0 images. Verified this works on my local setup
using roslyn in a Docker volume
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 6, 2023
@jaredpar
Copy link
Member Author

jaredpar commented Dec 6, 2023

@333fred, @dibarbet FYI ... I'm very green with devcontainer support so possible I'm making bad mistakes here.

"powershell.startAutomatically": false,
// ms-azure-devops.azure-pipelines settings
"azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json"
"customizations": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer versions of devcontainer.json wanted vscode specific settings under a vscode specific section. Did not change any settings here, just moved them under this section.

},
"extensions": [
"ms-dotnettools.csharp",
"ms-dotnettools.csdevkit",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one setting I did change was adding DevKit into the default extension list.

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 seems reasonable!

@jaredpar jaredpar merged commit 742f8eb into dotnet:main Dec 6, 2023
@jaredpar jaredpar deleted the container branch December 6, 2023 21:42
@ghost ghost added this to the Next milestone Dec 6, 2023
@Cosifne Cosifne modified the milestones: Next, 17.9 P3 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants