Write and read uniformly in objectwriter/objectreader #71877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jan 30, 2024
| case TypeCode.Null: return null; | ||
| case TypeCode.Boolean_True: return true; | ||
| case TypeCode.Boolean_False: return false; | ||
| case TypeCode.Int8: return _reader.ReadSByte(); |
There was a problem hiding this comment.
direct access of the reader makes the code harder to update since it's the reader itself that is being swapped out in the new world.
CyrusNajmabadi
commented
Jan 30, 2024
| if (value == null) | ||
| { | ||
| _writer.Write((byte)TypeCode.Null); | ||
| WriteByte((byte)TypeCode.Null); |
There was a problem hiding this comment.
same with direct access of the writer.
This is for "_writer.Write(word);" in case codeflow messed that up In reply to: 1917877589 Refers to: src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Serialization/ObjectWriter.cs:607 in 432d746. [](commit_id = 432d746, deletion_comment = False) |
Should WriteVersion be modified call WriteByte? In reply to: 1917878270 Refers to: src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Serialization/ObjectWriter.cs:607 in 432d746. [](commit_id = 432d746, deletion_comment = False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with a larger refactoring i'm making here to make it so that these readers/writers can be used efficiently on pipes.