Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix analyzer RCS1181 #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix analyzer RCS1181 #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb1ecd3
update
josefpihrt Sep 16, 2024
6705a2f
changelog
josefpihrt Sep 16, 2024
a2b794d
update
josefpihrt Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix analyzer [RCS0053](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS0053) ([PR](https://github.com/dotnet/roslynator/pull/1518))
- Fix analyzer [RCS0056](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS0056) ([PR](https://github.com/dotnet/roslynator/pull/1521))
- Fix analyzer [RCS1181](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1181) ([PR](https://github.com/dotnet/roslynator/pull/1526))

## [4.12.5] - 2024-09-13

Expand Down
13 changes: 0 additions & 13 deletions src/Analyzers/CSharp/Analysis/ConvertCommentToDocumentationCommentAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public override void Initialize(AnalysisContext context)
{
base.Initialize(context);

context.RegisterSyntaxNodeAction(f => AnalyzeNamespaceDeclaration(f), SyntaxKind.NamespaceDeclaration);
context.RegisterSyntaxNodeAction(f => AnalyzeClassDeclaration(f), SyntaxKind.ClassDeclaration);
context.RegisterSyntaxNodeAction(f => AnalyzeStructDeclaration(f), SyntaxKind.StructDeclaration);
#if ROSLYN_4_0
Expand All @@ -53,18 +52,6 @@ public override void Initialize(AnalysisContext context)
context.RegisterSyntaxNodeAction(f => AnalyzeEventDeclaration(f), SyntaxKind.EventDeclaration);
}

private static void AnalyzeNamespaceDeclaration(SyntaxNodeAnalysisContext context)
{
if (AnalyzeLeading(context))
return;

var namespaceDeclaration = (NamespaceDeclarationSyntax)context.Node;

TrailingAnalysis? analysis = AnalyzeTrailing(namespaceDeclaration.Name);

ReportDiagnostic(context, analysis);
}

private static void AnalyzeClassDeclaration(SyntaxNodeAnalysisContext context)
{
if (AnalyzeLeading(context))
Expand Down
12 changes: 12 additions & 0 deletions src/Tests/Analyzers.Tests/RCS1181ConvertCommentToDocumentationCommentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,4 +330,16 @@ void M1() //x
}
");
}

[Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.ConvertCommentToDocumentationComment)]
public async Task TestNoDiagnostic_NamespaceDeclaration()
{
await VerifyNoDiagnosticAsync(@"
namespace N // Some comment
{
class C
{
}
}");
}
}