-
-
Notifications
You must be signed in to change notification settings - Fork 273
Add support for GitLab output format in AnalyzeCommand #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds support for the GitLab output format in the AnalyzeCommand class. Signed-off-by: Marais van Zyl <[email protected]>
@dotnet-policy-service agree company="Verizon Connect" |
Signed-off-by: Marais van Zyl <[email protected]>
Signed-off-by: Marais van Zyl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. It just added a couple of comments.
build failed |
Also please update changelog |
…n the `DiagnosticGitLabJsonSerializer` class to centralize JSON serialization configuration.
@marais-vzc When you fix TryParse and update the changelog we can merge it. |
@marais-vzc Thank your for your contribution 🙏 Sorry that it took that long to merge it. I was a bit busy at work 🙂 |
No problem. Just happy that we got to get the change accepted. |
Fixes #1631
Add support for GitLab output format in AnalyzeCommand
This commit adds support for the GitLab output format in the
AnalyzeCommand
class. Now, when theOutputFormat
option is set to "gitlab", the analysis results will be serialized in the GitLab JSON format using theDiagnosticGitLabJsonSerializer
class, instead of the default XML format. This enables users to generate diagnostic reports compatible with GitLab's security scanning features.