-
Notifications
You must be signed in to change notification settings - Fork 5k
GetUnicode_Invalid/GetAscii_Invalid test failures on Fedora 40 #100287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @dotnet/area-system-globalization |
@tarekgh do you know what the root cause is for the test failures? Here is one of the cases that fails:
|
This test depends on the Unicode IDN data which changes with every new version. Look at https://github.com/dotnet/runtime/tree/main/src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Unicode_11_0 as example. To fix this, we'll need to pick a new data and tweak it a little to make it pass. |
Looks like libicu 74 uses Unicode 15.1: https://icu.unicode.org/download/74. I can look into adding this. Do we also need to explicitly add libicu 72/Unicode 15 support? Or libicu 70/Unicode 14 support? |
@omajid we can add both versions to ensure using different ICU versions will work. Please note, after porting the test data files, usually we comment some lines which are incompatible with our APIs. The best way to do that is just bring the data as it is, run the test, look at the failed entries and then we comment it. Thanks a lot for willing to help with that. |
I just checked things and the tests don't fail on Fedora 39, which has icu 73. Maybe there's no interesting changes in Unicode 14 or 15 that are relevant for our test suite? |
The test file IdnaTest_15_1.txt is a direct copy of https://www.unicode.org/Public/idna/15.1.0/IdnaTestV2.txt without any further changes. Fixes: dotnet#100287
The test file IdnaTest_15_1.txt is a direct copy of https://www.unicode.org/Public/idna/15.1.0/IdnaTestV2.txt without any further changes. Fixes: dotnet#100287
Thanks @omajid! |
Some System.Globalization.Extensions.Tests tests are failing on Fedora 40.
Fedora 40 has libicu 74.2-1.
GetUnicode_Invalid
: 158 out of 5421 failedGetAscii_Invalid
: 158 out of 5448 failedSee testResults.xml.txt
cc @tarekgh @omajid
The text was updated successfully, but these errors were encountered: