Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Question about Sse2 Intrinsics Tests And use of private static #113231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kkukshtel-unity opened this issue Mar 6, 2025 · 2 comments
Open

Question about Sse2 Intrinsics Tests And use of private static #113231

kkukshtel-unity opened this issue Mar 6, 2025 · 2 comments
Labels
area-System.Runtime.Intrinsics help wanted [up-for-grabs] Good issue for external contributors

Comments

@kkukshtel-unity
Copy link

Description

For the following files:

src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt32WithTruncation.Int32.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt64WithTruncation.Vector128Double.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToUInt64.Vector128UInt64.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToVector128Double.Double.cs

The tests on these are marked privateand are not tagged with the [Fact]attribute from XUnit.

Normally for Intrinsic tests, the convention seems to be that the main test entry method is public and marked [Fact]. I can't find any other reference to these specific test methods elsewhere in the codebase, so I'm wondering if they are meant to be ignored and are just kept around for legacy reasons. Or said differently, if we're trying to replicate your own testing infrastructure, what is the proper way to handle these files?

cc @tannergooding

Reproduction Steps

N/A

Expected behavior

N/A

Actual behavior

N/A

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 6, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member

These should likely be marked with [Fact]. It looks like they may have just been missed in the PR that upgraded most of the tests to use xUnit rather than be individual console apps that were launched.

@tannergooding tannergooding added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tannergooding @kkukshtel-unity