Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Duplicates in different config sources are treated differently #36557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajcvickers opened this issue Dec 7, 2018 · 5 comments
Closed

Duplicates in different config sources are treated differently #36557

ajcvickers opened this issue Dec 7, 2018 · 5 comments
Labels
area-Extensions-Configuration backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions no-recent-activity

Comments

@ajcvickers
Copy link
Contributor

See dotnet/extensions#600

Specifically, duplicates within a given source. For example, the same setting repeated twice in an .ini file.

These providers throw either ArgumentException or FormatException:

  • AzureKeyVault
  • Ini
  • KeyPerFile
  • XML
  • Memory

These providers ignore duplicates if the case does match:

  • Json

These providers ignore duplicates if the case does not match:

  • EnvironmentVariables

These providers ignore duplicates:

  • CommandLine
@ajcvickers
Copy link
Contributor Author

Notes from triage:

  • Providers that currently ignore duplicates should continue to do so to avoid breaking existing apps
  • For 3.0 we would consider a change that consolidated all the exception types/messages across providers into one consistent exception and message. (This is technically also a breaking change, but one that is unlikely to cause real-world issues. Still; better to do it in 3.0 than in a non-breaking release.)

@analogrelay analogrelay transferred this issue from dotnet/extensions May 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Extensions-Configuration untriaged New issue has not been triaged by the area owner labels May 15, 2020
@analogrelay analogrelay added this to the Future milestone May 15, 2020
@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Jul 1, 2020
@maryamariyan
Copy link
Member

This issue seems to have a dupe. I will link once I find it.

@maryamariyan maryamariyan added the enhancement Product code improvement that does NOT require public API changes/additions label Oct 19, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Apr 21, 2025
Copy link
Contributor

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@dotnet-policy-service dotnet-policy-service bot removed this from the Future milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Configuration backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions no-recent-activity
Projects
None yet
Development

No branches or pull requests

4 participants