[release/8.0-staging] Fix Http2 deadlock #100086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has low hit count, but it is a relaibility problem, a regression in 8.0 and low risk change -- we should consider to take it. Let's do bar check with Tactics. |
|
Approved by tactics (@SteveMCarroll) via email on April 2nd. |
rzikm
approved these changes
Apr 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99889 to release/8.0-staging
Fixes #98945
/cc @MihaZupan
Customer Impact
Reported by a customer in #98945.
It is a deadlock that can happen in a race when the server closes an HTTP/2 connection (which is not that common for HTTP/2).
Regression
Yes, introduced in 8.0 (likely in PR #90094).
Testing
Tested with a custom build of Libraries which introduces delays increasing the chances of the problem happening.
Risk
Low