Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement RuntimeHelpers.Box #100561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 6, 2024
Merged

Implement RuntimeHelpers.Box #100561

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
06776cd
Implement RuntimeHelpers.Box
jkoritzinsky Apr 2, 2024
b285704
PR feedback
jkoritzinsky Apr 3, 2024
a50ac34
Update src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/RuntimeE…
jkotas Apr 3, 2024
06f4e60
Remove stray token
jkoritzinsky Apr 3, 2024
db96ac7
Update RuntimeExports.cs
jkoritzinsky Apr 3, 2024
6f54fb5
RhBoxAny and RhBox have alternate-order argument lists.
jkoritzinsky Apr 3, 2024
e69e057
Fix formatting
jkoritzinsky Apr 3, 2024
bae1693
Add tests for void and generic type definitions and other feedback
jkoritzinsky Apr 4, 2024
d9e94dd
Skip test case on NativeAot
jkoritzinsky Apr 4, 2024
442be13
Add test for partially open generics
jkoritzinsky Apr 5, 2024
f7df0bf
Add doc comments
jkoritzinsky Apr 5, 2024
3e43be5
Add a remark about the box IL instruction
jkoritzinsky Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update RuntimeExports.cs 
Co-authored-by: Jan Kotas <[email protected]>
  • Loading branch information
@jkoritzinsky @jkotas
jkoritzinsky and jkotas authored Apr 3, 2024
commit db96ac7bcf43a186506dc58809e31e5f2a8845f7
3 changes: 1 addition & 2 deletions src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/RuntimeExports.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public static unsafe object RhNewArray(MethodTable* pEEType, int length)
public static unsafe object RhBox(MethodTable* pEEType, ref byte data)
{
// A null can be passed for boxing of a null ref.
if (Unsafe.IsNullRef(ref data))
throw new NullReferenceException();
_ = Unsafe.ReadUnaligned<byte>(ref data);

ref byte dataAdjustedForNullable = ref data;

Expand Down