[S390x] Fix stack offset size while passing structure as argument. #101103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @lambdageek, @steveisok |
This was referenced Apr 16, 2024
Closed
steveisok
reviewed
Apr 16, 2024
lambdageek
approved these changes
Apr 16, 2024
This was referenced Apr 17, 2024
|
@steveisok can we run the runtime-community CI ? |
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
There are no failures reported in s390x CI and other failures are unrelated. is this good to merge? |
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
re-running one more time. there was a hung CI job, and we can't merge on red anymore. |
This was referenced Apr 29, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when passing the arguments structure by reference we allocate extra un-necessary bytes in the stack (As it should only use 8 bytes for the reference address).
this example depicts when passing a structure of 16 bytes as an argument
before the patch:
after the patch: