Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable RuntimeType.GenericCache to hold multiple types of cache entries #102034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 31, 2024
Merged

Enable RuntimeType.GenericCache to hold multiple types of cache entries #102034

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
01ca1e8
Make the generic cache composite and encapsulate it
jkoritzinsky May 8, 2024
b565bee
Use InlineArray with Count to make the cache easier to expand. Scope …
jkoritzinsky May 8, 2024
28e4107
Update comment
jkoritzinsky May 8, 2024
893825e
Make the GenericCache more resilient to multithreading races.
jkoritzinsky May 9, 2024
2a59a5e
Add Debug.Assert and nonnull-assertion operator
jkoritzinsky May 9, 2024
dd7ae9e
Use a by-ref and explicitly use Cache vs CacheIfExists.
jkoritzinsky May 14, 2024
e74cd87
Do only one read in GetOrCreate.
jkoritzinsky May 14, 2024
a7e6737
Fix assignment in Create case
jkoritzinsky May 14, 2024
0f76725
Genericize more and remove more casts.
jkoritzinsky May 15, 2024
4013571
Force-inline static members to ensure they get non-shared instantiati…
jkoritzinsky May 16, 2024
be01bb3
Don't create two cache entries in the Activator.CreateInstance scenario
jkoritzinsky May 16, 2024
022350d
Remove unsafety and make CompositeCacheEntry implement IGenericCacheE…
jkoritzinsky May 16, 2024
0886ce7
Replace InlineArray with explicit fields
jkotas May 28, 2024
bdeb28b
Reimplement EnumInfo support
jkoritzinsky May 29, 2024
ae2be47
PR feedback
jkoritzinsky May 30, 2024
7adc3a6
Cleanup
jkoritzinsky May 30, 2024
982a1c4
Fix typo
jkoritzinsky May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed May 8, 2024
commit 28e4107de9d24bdcd297441f189147ad8cb57077
6 changes: 2 additions & 4 deletions src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,10 +1454,8 @@ internal T[] GetMemberList(MemberListType listType, string? name, CacheType cach
private static CerHashtable<RuntimeMethodInfo, RuntimeMethodInfo> s_methodInstantiations;
private static object? s_methodInstantiationsLock;
private string? m_defaultMemberName;
// Generic cache for rare scenario specific data. Used for:
// - Enum names and values (EnumInfo)
// - Activator.CreateInstance (ActivatorCache)
// - Array.Initialize (ArrayInitializeCache)
// Generic cache for rare scenario specific data.
// See IGenericCacheEntry for more information.
private object? m_genericCache;
private object[]? _emptyArray; // Object array cache for Attribute.GetCustomAttributes() pathological no-result case.
private RuntimeType? _genericTypeDefinition;
Expand Down