-
Notifications
You must be signed in to change notification settings - Fork 5.2k
DATAS tuning changes #102368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAS tuning changes #102368
Conversation
Tagging subscribers to this area: @dotnet/gc |
oops, I forgot to add the data. with this change you can see the true effect of adapting to size - (fix is running on the 28-core machine, aspnet-citrine-win; fix12c is running on 12-core, aspnet-perf-win). comparing with Server GC on the 28-core machine - RPS comparison the PlaintextMvc benchmark RPS is noticeable lower because DATAS limits how many heaps there are but these benchmarks allocate with different number of threads based on the machine they are running on (so Server GC has 28 heaps and DATAS has 15 heaps) which causes throughput drops. this benchmark is extremely allocation intense which causes this effect. this is something we can improve in the GC to accommodate. |
* DATAS tuning changes * fix debug build error * fix linux build error --------- Co-authored-by: Maoni0 <[email protected]>
tuning changes -
got rid of the following in DATAS - they were there as a proof of concept but really didn't work well at all -
hopefully now the code is also much easier to read than the previous big method (which I wrote in a hurry).
exclude factors that introduce volatility in budget computation in SVR GC - these can change the budget dramatically in a very predictable way
I'm really trying to make DATAS produce more predictable heap sizes. This is a very different philosophy from SVR GC.
diag is not done. Will come in a separate PR -
I'll add the comparison data tomorrow.