[mono] Fix hardcoded .NET 8.0 string in iOS sample #103117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always forget updating this string with new .NET releases so let's just not mention the version.
mkhamoyan
approved these changes
Jun 6, 2024
This was referenced Jun 6, 2024
|
/ba-g failures are unrelated |
|
You could also output the actual runtime version instead of a constant string. I think it is something like System.Evvironment.Version. |
|
@TonyValenti true but that'd involve more code that can potentially fail and the point of the sample is to be small. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always forget updating this string with new .NET releases so let's just not mention the version.