Dispose IDisposables in RegexGenerator #103142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StringWriter and IndentedTextWriter are IDisposable classes, so we should dispose them when we are done with them.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
stephentoub
approved these changes
Jun 6, 2024
|
Agreed. I am doing some static analysis using some tools and a tool is flagging these uses. Would you prefer to leave this out? |
No, it's fine. Like I said, it won't hurt :) |
This was referenced Jun 7, 2024
Open
Closed
gfoidl
reviewed
Jun 12, 2024
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Günther Foidl <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StringWriter and IndentedTextWriter are IDisposable classes, so we should dispose them when we are done with them.