ConfigXmlReader is an IDisposable; Dispose it #103163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was flagged by a static analysis tool. Is this necessary? Is this safe to do?
|
Tagging subscribers to this area: @dotnet/area-system-configuration |
|
I believe it's safe to do, but as with your previous PR, doesn't actually improve anything other than silencing whatever static analysis tool is being used: this reader is being constructed from a string, and there won't be any resources that need to be cleaned up. |
This was referenced Jun 7, 2024
Closed
stephentoub
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flagged by a static analysis tool. Is this necessary? Is this safe to do?