Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing includes for FreeBSD 14 in pal_networkstatistics.c #103187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2024
Merged

Add missing includes for FreeBSD 14 in pal_networkstatistics.c #103187

merged 3 commits into from
Jun 17, 2024

Conversation

Thefrank
Copy link
Contributor

@Thefrank Thefrank commented Jun 8, 2024

This patch is already in ports version of dotnet for FreeBSD.

This PR upstreams the patch with a FreeBSD ifdef

  In file included from /runtime/src/native/libs/System.Native/pal_networkstatistics.c:61:
  /crossrootfs/x64/usr/include/netinet/tcp_var.h:310:17: error: field has incomplete type 'struct callout'
          struct callout t_callout;
                         ^
  /crossrootfs/x64/usr/include/netinet/tcp_var.h:310:9: note: forward declaration of 'struct callout'
          struct callout t_callout;
                 ^
  /crossrootfs/x64/usr/include/netinet/tcp_var.h:471:13: error: field has incomplete type 'struct osd'
          struct osd      t_osd;          /* storage for Khelp module data */
                          ^
  /crossrootfs/x64/usr/include/netinet/tcp_var.h:471:9: note: forward declaration of 'struct osd'
          struct osd      t_osd;          /* storage for Khelp module data */
                 ^

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 8, 2024
This was referenced Jun 8, 2024
Closed
Closed
Closed
Closed
@Thefrank Thefrank mentioned this pull request Jun 15, 2024
Open
@jkotas jkotas added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 16, 2024
@jkotas jkotas requested a review from wfurt June 16, 2024 01:09
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt
wfurt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented Jun 17, 2024

all test failures are know problems.

@wfurt wfurt merged commit b7d8056 into dotnet:main Jun 17, 2024
@Thefrank Thefrank deleted the freebsd14 branch June 17, 2024 18:30
@karelz karelz added this to the 9.0.0 milestone Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Thefrank @wfurt @karelz @jkotas