Extend SearchValues<string> use in Regex to NonBacktracking #103496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously only enabled this for the compiler. Support it with NonBacktracking, too.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
This was referenced Jun 15, 2024
MihaZupan
approved these changes
Jun 17, 2024
.../System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexFindOptimizations.cs
Show resolved
Hide resolved
This was referenced Jun 25, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only enabled this for the compiler / source generator. Support it with NonBacktracking, too. We could easily enable it now for the interpreter as well... I've shied away from it not for technical reasons but because there is measurable cost associated with the analysis here, and we typically try to keep the interpreter construction relatively fast.