Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Intrinsify typeof(T).GetGenericTypeDefinition() #103528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jul 19, 2024
Merged

Intrinsify typeof(T).GetGenericTypeDefinition() #103528

merged 23 commits into from
Jul 19, 2024

Conversation

Sergio0694
Copy link
Contributor

@Sergio0694 Sergio0694 commented Jun 15, 2024 •
edited
Loading

Closes #96898

public static Type? Test1<T>() =>
    typeof(T).IsGenericType
    ? typeof(T).GetGenericTypeDefinition()
    : null;

Codegen diffs:

; Assembly listing for method Foo:Test1[System.Collections.Generic.KeyValuePair`2[System.__Canon,int]]():System.Type (FullOpts)

-   sub      rsp, 40
-   mov      qword ptr [rsp+0x20], rcx
-   mov      rcx, qword ptr [rcx+0x40]
-   mov      rcx, qword ptr [rcx]
-   call     CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE
-   mov      rcx, rax
-   call     [System.RuntimeType:GetGenericTypeDefinition():System.Type:this]
-   nop      
-   add      rsp, 40
+   mov      rax, 0x275000095B0
    ret
public static bool Test2<T>() =>
        typeof(T).IsGenericType &&
        typeof(T).GetGenericTypeDefinition() == typeof(KeyValuePair<,>);

Codegen diffs:

; Assembly listing for method Foo:Test2[System.Collections.Generic.KeyValuePair`2[System.__Canon,int]]():ubyte (FullOpts)

-   sub      rsp, 40
-   mov      qword ptr [rsp+0x20], rcx
-   mov      rcx, qword ptr [rcx+0x40]
-   mov      rcx, qword ptr [rcx]
-   call     CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE
-   mov      rcx, rax
-   call     [System.RuntimeType:GetGenericTypeDefinition():System.Type:this]
-   mov      rcx, 0x19F800095D8      ; 'System.Collections.Generic.KeyValuePair`2[TKey,TValue]'
-   cmp      rax, rcx
-   sete     al
-   movzx    rax, al
-   add      rsp, 40
+   mov      eax, 1
    ret

Note

Reopening from #97159 because the bot closed that one.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 15, 2024
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from c507e7c to 5beced9 Compare June 16, 2024 18:53
@Sergio0694
Copy link
Contributor Author

Sergio0694 commented Jun 16, 2024 •
edited
Loading

@MihuBot

@En3Tho
Copy link
Contributor

En3Tho commented Jun 16, 2024

@Sergio0694 wrong command it seems? Box => bot

@MihuBot MihuBot mentioned this pull request Jun 16, 2024
Open
@Sergio0694
Copy link
Contributor Author

Oops, typo, thank you! 😅

Sergio0694
Sergio0694 commented Jun 16, 2024
View reviewed changes
@Sergio0694 Sergio0694 marked this pull request as ready for review June 16, 2024 21:00
@Sergio0694
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Jun 16, 2024
Open
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 2a88644 to 60c34f3 Compare June 16, 2024 21:37
This was referenced Jun 17, 2024
Closed
Open
Closed
EgorBo
EgorBo reviewed Jun 17, 2024
View reviewed changes
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 17, 2024
Closed
Closed
Closed
Open
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
@EgorBo
Copy link
Member

EgorBo commented Jun 17, 2024

@MihuBot

@MihuBot MihuBot mentioned this pull request Jun 17, 2024
Open
@Sergio0694 Sergio0694 mentioned this pull request Jun 17, 2024
Open
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 76c655c to 8cc0189 Compare July 10, 2024 07:02
@Sergio0694 Sergio0694 requested a review from EgorBo July 10, 2024 07:05
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Closed
EgorBo
EgorBo reviewed Jul 10, 2024
View reviewed changes
This was referenced Jul 19, 2024
Closed
Closed
Sergio0694 and others added 23 commits July 19, 2024 11:08
@Sergio0694
Add getTypeDefinition definition
f5c77e5
@Sergio0694
Implement CEEInfo::getTypeDefinition
7b27bb2
@Sergio0694
Tweak CEEInfo::getTypeDefinition
f7e8951
@Sergio0694
Make Type.GetGenericTypeDefinition() an intrinsic
9d6ec48
@Sergio0694
Add GetGenericTypeDefinition() intrinsic tests
b537505
@Sergio0694
Only expand intrinsic for generic types
a02c9a1
@Sergio0694
Use normal JIT_TO_EE transition
23f8ebc
@Sergio0694
Apply review suggestions for CEEInfo::getTypeDefinition
d6a925d
@Sergio0694
Implement managed version of getTypeDefinition
cf937db
@Sergio0694
Fix EE_TO_JIT transition
98952fc
@Sergio0694
Implement missing superPMI methods
f65d626
@Sergio0694
Remove extra blank line
cfad15d
@Sergio0694
Add missing handle -> 'Type' conversion
f3b5402
@Sergio0694
Add '__Canon' tests as well
b44805d
@Sergio0694
Add tests for failure cases as well
447f949
@Sergio0694
Run ThunkGenerator again
1ccc84f
@Sergio0694
Add docs for 'impGetGenericTypeDefinition'
7175c3a
@Sergio0694
Add assert in 'getTypeDefinition'
ae66298
@Sergio0694 @jkotas
Remove assert
9a2aa1e 
Co-authored-by: Jan Kotas <[email protected]>
@Sergio0694 @jkotas
Allow non instantiated generics in new JIT interface method
a2eb42e 
Co-authored-by: Jan Kotas <[email protected]>
@Sergio0694
Update docs for 'getTypeDefinition'
a2a8d60
@Sergio0694
Tweak condition in 'CEEInfo::getTypeDefinition'
89319d7
@Sergio0694
Run ThunkGenerator again
4cbe7f3
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/get-generic-type-definition-intrinsic branch from 7f0594b to 4cbe7f3 Compare July 19, 2024 18:08
@EgorBo
Copy link
Member

EgorBo commented Jul 19, 2024 •
edited
Loading

Failures are unrelated and changes in the recent force push look good, merging

@EgorBo EgorBo merged commit 5ee8f4a into dotnet:main Jul 19, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 19, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Type.IsGenericType and GetGenericTypeDefinition() JIT intrinsics (and JIT time constants)
5 participants
@Sergio0694 @En3Tho @EgorBo @kasperk81 @jkotas