Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Add support for SwiftIndirectResult in Swift calling convention #103570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 18, 2024
Merged

JIT: Add support for SwiftIndirectResult in Swift calling convention #103570

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
07b417f
Add test for SwiftIndirectResult
jakobbotsch Jun 17, 2024
889a2e5
Fix test
jakobbotsch Jun 17, 2024
1e71cf2
unmanaged
jakobbotsch Jun 17, 2024
a68f138
Unsafe, pass indirect result correctly
jakobbotsch Jun 17, 2024
1103717
Add to CMake files
jakobbotsch Jun 17, 2024
3726cbf
Add support for SwiftIndirectResult
jakobbotsch Jun 17, 2024
0db1d8f
Fix export name
jakobbotsch Jun 17, 2024
b00a2fa
Enable library evolution
jakobbotsch Jun 17, 2024
ceee815
Reverse pinvoke support
jakobbotsch Jun 17, 2024
b4dabd0
Use a separate local for Swift indirect result parameter
jakobbotsch Jun 17, 2024
4f410da
Fix ret buf handling now that it is a struct in some cases
jakobbotsch Jun 17, 2024
e1bc2e8
Run jit-format
jakobbotsch Jun 17, 2024
8dc1931
Disable new test on Mono
jakobbotsch Jun 17, 2024
deae39e
Clean up
jakobbotsch Jun 17, 2024
974f37a
Enable library evolution in all Swift tests
jakobbotsch Jun 17, 2024
e05c282
Revert "Enable library evolution in all Swift tests"
jakobbotsch Jun 17, 2024
3024b10
Move comment
jakobbotsch Jun 18, 2024
18ab440
Merge branch 'main' of github.com:dotnet/runtime into swift-indirect-…
jakobbotsch Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move comment
  • Loading branch information
@jakobbotsch
jakobbotsch committed Jun 18, 2024
commit 3024b100edb71365a399f2ac9808f8fc40f3c1f5
6 changes: 3 additions & 3 deletions src/coreclr/jit/importercalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,7 +2072,9 @@ void Compiler::impPopArgsForSwiftCall(GenTreeCall* call, CORINFO_SIG_INFO* sig,
}

swiftErrorIndex = argIndex;
spillStack = true;
// Spill entire stack as we will need to reuse the error
// argument after the call.
spillStack = true;
}
else if ((strcmp(className, "SwiftSelf") == 0) &&
(strcmp(namespaceName, "System.Runtime.InteropServices.Swift") == 0))
Expand Down Expand Up @@ -2135,8 +2137,6 @@ void Compiler::impPopArgsForSwiftCall(GenTreeCall* call, CORINFO_SIG_INFO* sig,
}
}

// If using SwiftError*, spill entire stack as we will need to reuse the
// error argument after the call.
if (spillStack)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this comment to mention the SwiftIndirectResult case, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the existing comment up to where we assign spillStack in the SwiftError* case instead (there is already a comment on the new spillStack = true I added)

{
impSpillSideEffects(true, CHECK_SPILL_ALL DEBUGARG("Spill for swift call"));
Expand Down