Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Arm AdvSimd: Rename StoreVectorMxN to Store #103689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2024
Merged

Arm AdvSimd: Rename StoreVectorMxN to Store #103689

merged 4 commits into from
Jun 20, 2024

Conversation

SwapnilGaikwad
Copy link
Contributor

Partially (item 3) fixes: #102340

@ghost
Copy link

ghost commented Jun 19, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jun 19, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@SwapnilGaikwad
Copy link
Contributor Author

Hi @kunalspathak , this addresses the final (item 3) from #102340.
Didn't change mono bits.

@a74nh

@SwapnilGaikwad SwapnilGaikwad marked this pull request as ready for review June 19, 2024 11:35
@build-analysis build-analysis bot mentioned this pull request Jun 19, 2024
Closed
kunalspathak
kunalspathak suggested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments.

@kunalspathak
Copy link
Contributor

@SwapnilGaikwad - it seems there are some test failures:


Assert failure(PID 85467 [0x00014ddb], Thread: 2420517 [0x24ef25]): Assertion failed '!HWIntrinsicInfo::IsInvalidNodeId(intrinsicId)' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.Storex2SByteTest:RunBasicScenario_UnsafeRead():this' during 'Importation' (IL size 112; hash 0x4100adc6; MinOpts)

    File: /Users/runner/work/1/s/src/coreclr/jit/gentree.cpp:28149
    Image: /private/tmp/helix/working/A1D908D4/p/corerun

@fanyang-mono
Copy link
Member

Test AdvSimd_r.dll passed locally

Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        False
  Rdm:       False
  Sha1:      True
  Sha256:    True
  Sve:       False

...

Expected: 100
Actual: 100
END EXECUTION - PASSED

fanyang-mono
fanyang-mono approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mono change is good and complete.

kunalspathak
kunalspathak approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreclr LGTM.

This was referenced Jun 19, 2024
Closed
Open
Closed
Open
Closed
@kunalspathak
Copy link
Contributor

/ba-g the only failure on windows/x64 is unrelated and seems flaky

@kunalspathak kunalspathak merged commit ab013a3 into dotnet:main Jun 20, 2024
@SwapnilGaikwad SwapnilGaikwad deleted the github-rename-storeVectorNxM branch June 20, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

+1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arm64: Rename AdvSimd/Sve Load/Store vector API names
3 participants
@SwapnilGaikwad @kunalspathak @fanyang-mono