Extract shared IL pattern analysis to a class #103701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem discussed at dotnet#102248 (comment). Now we call into the same code from both substitutions and scanner.
|
SmokeTests not expected to be green without #103696 but it's such a corner case that it shouldn't matter elsewhere. |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/tests/nativeaot/SmokeTests/TrimmingBehaviors/DeadCodeElimination.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 20, 2024
This was referenced Jun 21, 2024
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dotnet/ilc-contrib could someone have a look please? This is a refactor to allow more code sharing and a building block for #103883 (that currently has this PR inlined into it) that brings up to 7% size savings for scenarios where this kicks in really well. |
|
@sbomer Can you take a look? |
jkotas
reviewed
Jun 27, 2024
jkotas
reviewed
Jun 28, 2024
jkotas
reviewed
Jun 28, 2024
src/coreclr/tools/aot/ILCompiler.Compiler/IL/TypeEqualityPatternAnalyzer.cs
Show resolved
Hide resolved
sbomer
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem discussed at #102248 (comment). Now we call into the same code from both substitutions and scanner.
Cc @dotnet/ilc-contrib