JIT: Handle TYP_DOUBLE on arm softFP similarly to TYP_LONG #103869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids `PUTARG_REG` being a multi-reg node on arm32 to handle this special case.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jun 23, 2024
Open
|
cc @dotnet/jit-contrib PTAL @dotnet/samsung @kunalspathak |
tomeksowi
approved these changes
Jun 24, 2024
t-mustafin
approved these changes
Jun 24, 2024
clamp03
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids
PUTARG_REGbeing a multi-reg node on arm32 to handle this special case.The gist of the change: we expect multi-reg structs, including
TYP_LONGon arm32/x86, to be put into aFIELD_LIST(PUTARG_REG(low), PUTARG_REG(high))form before LSRA. For multi-reg structs this happens during morph, while forTYP_LONGwe keep them as primitives until lowering, so it happens during lowering.There was a special case for arm32 with softFP where
TYP_DOUBLEalso ends up being a similar multi-reg struct that is passed in two integer registers. There was a bunch of special casing to handle this in the backend, by makingPUTARG_REGandBITCASTmultireg nodes on arm32 only.This PR instead puts
TYP_DOUBLEinto the expected multireg-struct form during lowering, allowing it to be handled like any other multireg struct.Motivation is to avoid arm32-specific logic in #103866, which currently fails in CI for arm32 softFP because of this special case.