Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve perf of JsonValue.CreateFromElement by calling ValueKind once #104108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Improve perf of JsonValue.CreateFromElement by calling ValueKind once #104108

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cb3031
Improve perf of JsonValue.CreateFromElement by calling JsonElement.Va…
andrewjsaid Jun 27, 2024
50c06be
Use switch statement instead of multiple ifs
andrewjsaid Jun 27, 2024
a0d762d
Update src/libraries/System.Text.Json/src/System/Text/Json/Nodes/Json…
eiriktsarpalis Jun 27, 2024
8d376f9
Update src/libraries/System.Text.Json/src/System/Text/Json/Nodes/Json…
eiriktsarpalis Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use switch statement instead of multiple ifs
  • Loading branch information
@andrewjsaid
andrewjsaid committed Jun 27, 2024
commit 50c06bef90a6eb8bfdfc51840e304e0114d18df3
25 changes: 13 additions & 12 deletions src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Text.Json.Serialization;
Expand Down Expand Up @@ -181,20 +180,22 @@ internal static JsonValue CreateFromTypeInfo<T>(T value, JsonTypeInfo<T> jsonTyp

internal static JsonValue? CreateFromElement(ref readonly JsonElement element, JsonNodeOptions? options = null)
{
JsonValueKind kind = element.ValueKind;

if (kind is JsonValueKind.Null)
switch (element.ValueKind)
{
return null;
}
case JsonValueKind.Null:
return null;

// Force usage of JsonArray and JsonObject instead of supporting those in an JsonValue.
if (kind is JsonValueKind.Object or JsonValueKind.Array)
{
ThrowHelper.ThrowInvalidOperationException_NodeElementCannotBeObjectOrArray();
}
case JsonValueKind.Object:
case JsonValueKind.Array:
// Force usage of JsonArray and JsonObject instead of supporting those in an JsonValue.
ThrowHelper.ThrowInvalidOperationException_NodeElementCannotBeObjectOrArray();

// The above method will throw, but the compiler doesn't know that.
return default;

return new JsonValueOfElement(element, options);
default:
return new JsonValueOfElement(element, options);
}
}
}
}