-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Reimplement LINQ ToList using SegmentedArrayBuilder to reduce allocations #104365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-linq |
This was referenced Jul 3, 2024
Open
stephentoub
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
src/libraries/System.Linq/src/System/Linq/SegmentedArrayBuilder.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Linq
community-contribution
Indicates that the PR has been added by a community member
tenet-performance
Performance related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #96570,
ToArray()
in many places is faster and has fewer allocations thatToList()
. As aList
is just a wrapper over an array, we can re-use most of the logic inSegmentedArrayBuilder
to buildList
s, too.There were some more complex cases using
SegmentedArrayBuilder
for exampleConcat
where I left the code as-is. I can also experiment with performance numbers for those if it is requested.Benchmarks
Enumerable_ToList changes have been reverted, they are not in current PR version
Int32Tests
ObjectTests
Benchmark Code
Command Line
Program.cs
Performance Analysis
In all cases allocations are down and sometimes significantly so. As the size of the collection increases so do the savings due to reduced number of "unnecessary" array copies as the list grows.
Speed is more of a trade-off. For lower counts the PR is actually slower whereas for higher counts it is faster, again due to less time copying data around.
However this must be seen in context; we are trading off nanoseconds. In situations where nanoseconds of individual LINQ operations matter, it would probably be recommended to write the loops by hand anyway. On this basis I would say that creating less garbage to collect would probably be better for the overall system performance than the slower code for the Count less than 5 case.