Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable "Allocate on stack" for NAOT/R2R #104411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 14, 2024
Merged

Enable "Allocate on stack" for NAOT/R2R #104411

Changes from 4 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
000b528
Enable "Allocate on stack" for NAOT/R2R
EgorBo Jul 4, 2024
67b495d
Fix getClassGClayout on NAOT
EgorBo Jul 4, 2024
8e0e9eb
Handle CORINFO_HELP_UNBOX_TYPETEST on NAOT/R2R
EgorBo Jul 4, 2024
2a62eeb
fix build
EgorBo Jul 4, 2024
741e4fa
implement RhUnboxTypeTest
EgorBo Jul 5, 2024
396677b
Update ILCompiler.RyuJit.csproj
EgorBo Jul 5, 2024
19936e7
Update StackAllocatedBox.cs
EgorBo Jul 5, 2024
b07c1a0
clean up
EgorBo Jul 5, 2024
ea65a01
Update src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
EgorBo Jul 10, 2024
62b67d1
Merge branch 'main' of github.com:dotnet/runtime into alloc-stack-naot
EgorBo Jul 10, 2024
ebd8f9a
Add tests
EgorBo Jul 10, 2024
b5985a5
Address feedback
EgorBo Jul 10, 2024
1ef6ccf
Merge branch 'main' of github.com:dotnet/runtime into alloc-stack-naot
EgorBo Jul 11, 2024
4f9ff46
Update ObjectStackAllocationTests.cs
EgorBo Jul 12, 2024
ac65ff6
Update ObjectStackAllocationTests.cs
EgorBo Jul 12, 2024
203593c
Merge branch 'main' into alloc-stack-naot
EgorBo Jul 12, 2024
001b01c
Merge branch 'alloc-stack-naot' of github.com:EgorBo/runtime-1 into a…
EgorBo Jul 13, 2024
ac0e6e8
Merge branch 'main' of github.com:dotnet/runtime into alloc-stack-naot
EgorBo Jul 13, 2024
ed2568c
Clean up in the test
EgorBo Jul 13, 2024
d6a32b3
Update ObjectStackAllocationTests.csproj
EgorBo Jul 14, 2024
85340ae
Update ObjectStackAllocationTests.cs
EgorBo Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tests/JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ static bool SPCOptimizationsEnabled()
Assembly objectAssembly = Assembly.GetAssembly(typeof(object));
object[] attribs = objectAssembly.GetCustomAttributes(typeof(DebuggableAttribute),
false);
if (attribs.Length == 0)
return true; // Assume corelib is optimized in this case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding <DebuggerSupport>true</DebuggerSupport> to the project file would make the attribute visible, but ILC has its own optimization switch so CoreLib having this attribute still doesn't necessarily imply how optimized it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalStrehovsky do we run runtime tests with NativeAOT in full debug mode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So can you tell me how to properly check it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalStrehovsky do we run runtime tests with NativeAOT in full debug mode?

We do have such legs, I'm not sure if they include this test too. It would be in the runtime or runtime-nativeaot-outerloop if it exists.

So can you tell me how to properly check it here?

Native AOT will use the same settings for optimizing both CoreLib and user code so enabling the attribute and looking for the attribute on Assembly.GetEntryAssembly would give the answer.

I guess I don't understand why this is looking at whether corelib is optimized. Why does that affect stack allocations in this test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't understand why this is looking at whether corelib is optimized. Why does that affect stack allocations in this test?

Maybe the way we build the tests, optimization of CoreLib always matches optimization of the test?

If that's the case, all that's needed is to add <DebuggerSupport>true</DebuggerSupport> to the test project and this will work the same. It will also fail the same if there's ever mismatch between test optimization and corelib optimization.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't understand why this is looking at whether corelib is optimized. Why does that affect stack allocations in this test?

I am not the original author (I presume the authors no longer work in the team), but looks like the test tries to be agile and validate that nothing is stack-allocated under debug maybe? 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the original author (I presume the authors no longer work in the team), but looks like the test tries to be agile and validate that nothing is stack-allocated under debug maybe?

Right, but for that one would check whether the test is optimized, not corelib. One can build the test with <Optimize>true</Optimize> and have corelib from a debug build. I assume the test would fail in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I mean in the JIT case. It would also fail in the AOT case because I believe the test is looking at the wrong assembly.)

Copy link
Member Author

@EgorBo EgorBo Jul 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up removing these bits and the test is still working fine (it's always optimized due to <Optimize>true</Optimize>)

DebuggableAttribute debuggableAttribute = attribs[0] as DebuggableAttribute;
return ((debuggableAttribute == null) || !debuggableAttribute.IsJITOptimizerDisabled);
}
Expand Down